Skip to content

[stdlib] Fix the abi checker test for both assert and no-assert builds #20413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2018
Merged

[stdlib] Fix the abi checker test for both assert and no-assert builds #20413

merged 1 commit into from
Nov 8, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Nov 8, 2018

A few internal functions were defined within the #if
INTERNAL_CHECKS_ENABLED block, which made the results different between
stdlib configurations with assertions enabled and without. Since these
fucntions are internal and are not @inlinable, it is OK to have them
unconditionally.

rdar://problem/45880586

@moiseev
[stdlib] Fix the abi checker test for both assert and no-assert builds
938094c 
A few internal functions were defined within the #if
INTERNAL_CHECKS_ENABLED block, which made the results different between
stdlib configurations with assertions enabled and without. Since these
fucntions are internal and are not @inlinable, it is OK to have them
unconditionally.

<rdar://problem/45880586>
@moiseev
Copy link
Contributor Author

moiseev commented Nov 8, 2018

@swift-ci Please smoke test

@moiseev
Copy link
Contributor Author

moiseev commented Nov 8, 2018

Linux build error:

lookup error: /home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/buildbot_linux/swiftpm-linux-x86_64/.bootstrap/bin/../lib/swift/linux/libFoundation.so: undefined symbol: uregex_open_55

@moiseev
Copy link
Contributor Author

moiseev commented Nov 8, 2018

@swift-ci Please smoke test Linux platform

1 similar comment
@moiseev
Copy link
Contributor Author

moiseev commented Nov 8, 2018

@swift-ci Please smoke test Linux platform

@moiseev moiseev merged commit cc9c4fa into swiftlang:master Nov 8, 2018
@moiseev moiseev deleted the no-guards branch November 8, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moiseev