Skip to content

[stdlib] Fix the abi checker test for both assert and no-assert builds #20413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2018
Merged

[stdlib] Fix the abi checker test for both assert and no-assert builds #20413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions stdlib/public/core/Runtime.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ func _stdlib_atomicLoadARCRef(
// These pieces are used in ThreadLocalStorage.swift in debug builds.
// For tests, see similar functions from SwiftPrivate/AtomicInt.swift.gyb
//===----------------------------------------------------------------------===//
#if INTERNAL_CHECKS_ENABLED
internal func _swift_stdlib_atomicLoadInt(
object target: UnsafeMutablePointer<Int>) -> Int {
#if arch(i386) || arch(arm)
Expand All @@ -133,7 +132,6 @@ internal func _swift_stdlib_atomicLoadInt(
% for bits in [ 32, 64 ]:

// Warning: no overflow checking.
@inlinable // FIXME(sil-serialize-all)
internal func _swift_stdlib_atomicFetchAddInt${bits}(
object target: UnsafeMutablePointer<Int${bits}>,
operand: Int${bits}) -> Int${bits} {
Expand Down Expand Up @@ -162,7 +160,6 @@ internal func _swift_stdlib_atomicFetchAddInt(
#endif
return Int(value)
}
#endif // INTERNAL_CHECKS_ENABLED
//===----------------------------------------------------------------------===//

//===----------------------------------------------------------------------===//
Expand Down
2 changes: 2 additions & 0 deletions test/api-digester/Outputs/stability-stdlib-abi.swift.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ Func _stdlib_atomicCompareExchangeStrongInt64(object:expected:desired:) has been
Func _stdlib_atomicCompareExchangeStrongUInt32(object:expected:desired:) has been removed
Func _stdlib_atomicCompareExchangeStrongUInt64(object:expected:desired:) has been removed
Func _swift_stdlib_atomicFetchAddInt(object:operand:) has been removed
Func _swift_stdlib_atomicFetchAddInt32(object:operand:) has been removed
Func _swift_stdlib_atomicFetchAddInt64(object:operand:) has been removed
Func _swift_stdlib_atomicFetchAddUInt32(object:operand:) has been removed
Func _swift_stdlib_atomicFetchAddUInt64(object:operand:) has been removed
Func _swift_stdlib_atomicFetchAndInt(object:operand:) has been removed
Expand Down