Skip to content

Fix abi_v7k.swift test #20587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix abi_v7k.swift test #20587

merged 1 commit into from
Nov 15, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Nov 15, 2018

The test seems to rely on the fact that Double.init(_: Int) gets inlined
in -Onone.

Fixes: rdar://problem/45306568

The test seems to rely on the fact that Double.init(_: Int) gets inlined
in -Onone.

Fixes: <rdar://problem/45306568>
@moiseev
Copy link
Contributor Author

moiseev commented Nov 15, 2018

@swift-ci Please test

@moiseev moiseev assigned eeckstein and unassigned eeckstein Nov 15, 2018
@moiseev moiseev requested a review from eeckstein November 15, 2018 00:33
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inline(__almost_always) :-)

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@moiseev moiseev merged commit af13914 into swiftlang:master Nov 15, 2018
@moiseev moiseev deleted the v7k-fix branch November 15, 2018 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants