Skip to content

Fix abi_v7k.swift test #20587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix abi_v7k.swift test #20587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stdlib/public/core/FloatingPointTypes.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,8 +1625,9 @@ extension ${Self} {

// We "shouldn't" need this, but the typechecker barfs on an expression
// in the test suite without it.
@inlinable // FIXME(inline-always)
@inline(__always)
// If replaced with @inline(__always) the init no longer gets
// inlined in -Onone and this breaks the abi_v7k test in a subtle way.
@_transparent
public init(_ v: Int) {
_value = Builtin.sitofp_Int${word_bits}_FPIEEE${bits}(v._value)
}
Expand Down
3 changes: 1 addition & 2 deletions test/IRGen/abi_v7k.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

// REQUIRES: CPU=armv7k
// REQUIRES: OS=watchos
// REQUIRES: rdar45306568

// CHECK-LABEL: define hidden swiftcc float @"$s8test_v7k9addFloats{{.*}}"(float, float)
// CHECK: fadd float %0, %1
Expand Down Expand Up @@ -179,7 +178,7 @@ func testSingleP(x: SinglePayload) -> Double {
// V7K-LABEL: _$s8test_v7k0A6MultiP
// V7K: vldr d16, [sp{{.*}}]
// V7K: vmov.f64 d0, d16
// V7K: pop {{{.*}}}
// V7K: bx lr
// Backend will assign r0, r1 and r2 for input parameters and d0 for return values.
class Bignum {}
enum MultiPayload {
Expand Down