Skip to content

[CodeCompletion] Don't suggest values before declaration #20677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[CodeCompletion] Don't suggest values before declaration #20677

wants to merge 1 commit into from

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Nov 19, 2018 •
edited
Loading

Filter out unusable local value decls from completions. Note that local types are usable even before declaration. E.g. the following code is legal.

  func foo() {
    _ = SAlias()
    typealias SAlias = S
    struct S {}
  }

rdar://problem/25068938

@rintaro
[CodeCompletion] Don't suggest values before declaration
204170c 
Implement local value filter to filter out unusable value decls from
completions. Note that local types are usable even before declaration.
E.g. the following code is legal.

  func foo() {
    _ = S()
    struct S {}
  }

rdar://problem/25068938
@rintaro rintaro requested a review from benlangmuir November 19, 2018 12:37
@rintaro
Copy link
Member Author

rintaro commented Nov 19, 2018

@swift-ci Please smoke test

@rintaro rintaro mentioned this pull request Nov 30, 2018
Merged
@rintaro rintaro closed this Nov 30, 2018
@rintaro rintaro deleted the ide-codecompletion-rdar25068938 branch December 4, 2018 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro