[AST] Don't suggest unusable values for typo correction and code completion #20904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
Supersedes #20677. @benlangmuir |
benlangmuir
approved these changes
Nov 30, 2018
lib/AST/LookupVisibleDecls.cpp
Outdated
| SourceLoc Loc; | ||
| VisibleDeclConsumer &Consumer; | ||
|
|
||
| bool checkLocalValue(ValueDecl *VD, DeclVisibilityKind Reason) { |
There was a problem hiding this comment.
Please rename this to something that makes it clear what true and false return values mean - e.g. isUsableLocalValue.
lib/AST/LookupVisibleDecls.cpp
Outdated
|
|
||
| switch (Reason) { | ||
| case DeclVisibilityKind::LocalVariable: | ||
| // Use 'TypeDecl's before declaration is allowed. |
|
@DougGregor may also have opinions here from his work on ASTScope. (Specifically, lookupVisibleDecls isn't supposed to produce these invalid values in the first place.) |
rintaro
force-pushed
the
ast-lookupvisibledecls-forward
branch
from
d417025 to
1f17088
Compare
…letion Filter out these cases: - use within its own initial value - use before declaration for local values rdar://problem/25068938
rintaro
force-pushed
the
ast-lookupvisibledecls-forward
branch
from
1f17088 to
a54d2ff
Compare
|
@swift-ci Please smoke test |
DougGregor
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter out:
rdar://problem/25068938