[CodeCompletion] Fix call arguments completion in overloaded case #20721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify call-site code.
rintaro
force-pushed
the
ide-completion-postfixparen-rdar43703157
branch
from
bd723da to
5fdf8ee
Compare
|
@swift-ci Please smoke test |
|
Will this work for individual label completions (i.e. what you get in |
|
That's still FIXME. ( For example, given: func foo(arg1: Int, bar: Double) {}
func foo(arg1: Int, baz: Int){}
func foo(arg1: String, qux: Int) {}
func _test() {
foo(arg1: 1, #^COMPLETE^#
}results: But |
benlangmuir
approved these changes
Nov 26, 2018
lib/IDE/CodeCompletion.cpp
Outdated
|
|
||
| void collectPossibleParamListByQualifiedLookup( | ||
| /// Collect function (or subscript) member with specified \p name on \p baseTy. | ||
| void collectPossibleCalleeByQualifiedLookup( |
lib/IDE/CodeCompletion.cpp
Outdated
| void collectPossibleParamListByQualifiedLookup( | ||
| /// Collect function (or subscript) member with specified \p name on | ||
| /// \p baseExpr expression. | ||
| void collectPossibleCalleeByQualifiedLookup( |
There was a problem hiding this comment.
Same comments about function name and comment as above.
lib/IDE/CodeCompletion.cpp
Outdated
|
|
||
| void collectPossibleParamListByQualifiedLookup( | ||
| /// Collect function (or subscript) member with specified \p name on \p baseTy. |
There was a problem hiding this comment.
... members with the given \p name ...
lib/IDE/CodeCompletion.cpp
Outdated
| } | ||
|
|
||
| bool collectPossibleParamListsApply( | ||
| /// For given \c callExpr, collect possible callee types and declarations. | ||
| bool collectPossibleCalleeForApply( |
lib/IDE/CodeCompletion.cpp
Outdated
| DC, baseTy, DeclBaseName::createConstructor(), candidates); | ||
| } | ||
| } | ||
|
|
||
| return !candidates.empty(); | ||
| } | ||
|
|
||
| bool collectPossibleParamListsSubscript( | ||
| /// For given \c subscriptExpr, collect possible callee types and declarations. | ||
| bool collectPossibleCalleeForSubscript( |
lib/IDE/CodeCompletion.cpp
Outdated
| DeclBaseName::createSubscript(), | ||
| candidates); | ||
| } | ||
| return !candidates.empty(); | ||
| } | ||
|
|
||
| /// Get index of \p CCExpr in \p Args. \p Args is usually a \c TupleExpr, | ||
| /// \c ParenExpr, or a \c TupleShuffleExpr. | ||
| /// Returns \c true if sucess, \c false if \p CCExpr is not a part of \p Args. |
in context type analysis. Still NFC, but this is needed by later commits.
In `<expr> '(' <code-completion-token>` case, we usually complete call
arguments. If '<expr>' isn't typechecked, for example, because of
overloading, we used to give up arguments completions.
Now, use possible callee informations from the context type analyzer. This
increases the chance to provide accurate completions.
rdar://problem/43703157
rintaro
force-pushed
the
ide-completion-postfixparen-rdar43703157
branch
from
5fdf8ee to
0e4ce12
Compare
rintaro
force-pushed
the
ide-completion-postfixparen-rdar43703157
branch
from
0e4ce12 to
56c531d
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
<expr> '(' <code-completion-token>case, we usually complete call arguments. However, if<expr>isn't typechecked, for example because of overloading, we used to give up arguments completions.Now, use possible callee informations from
CodeCompletionTypeContextAnalyzer. This increases the chance to provide arguments completions.rdar://problem/43703157
(#20703 is a groundwork for this PR)