[5.0][CodeCompletion] Fix call arguments completion in overloaded case #20797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These functions are only used by CodeCompletionTypeContextAnalyzer. Move them into it. (cherry picked from commit bd4f20d)
To simplify call-site code. (cherry picked from commit 1af8078)
in context type analysis. Still NFC, but this is needed by later commits. (cherry picked from commit 8a6c540)
In `<expr> '(' <code-completion-token>` case, we usually complete call
arguments. If '<expr>' isn't typechecked, for example, because of
overloading, we used to give up arguments completions.
Now, use possible callee informations from the context type analyzer. This
increases the chance to provide accurate completions.
rdar://problem/43703157
(cherry picked from commit c55d6ce)
(cherry picked from commit 56c531d)
akyrtzi
approved these changes
Nov 27, 2018
Accept `getInterfaceType->hasError()` declarations. Even if the part of
the declaration has error, we still have chance to get context info from
the other part of it. For instance:
func foo(x: Int, y: INt) { }
foo(x: #^COMPLETE^#
We should resolve 'Int' as the context type even if parameter `y` is an
error type.
(cherry picked from commit 337d53f)
|
Added cherry-pick of #20964 because it's related. rdar://problem/46311661 |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Cherry-pick of #20703 and #20721 to swift-5.0-branch)
Not critical for convergence. Not ABI-affecting.
In
<expr> '(' <code-completion-token>case, we usually complete call arguments. However, if<expr>isn't typechecked, for example because of overloading, we used to give up arguments completions.Now, use possible callee informations from
CodeCompletionTypeContextAnalyzer. This increases the chance to provide arguments completions.rdar://problem/41147232
rdar://problem/43703157