Change Default Linker to Gold for AArch64 #20845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I don't know of any common platforms where gold wouldn't be available but BFD would. |
|
@jckarter - windows is one! But, after the windows stuff, I really feel like just giving up and unifying on lld seems much easier and will allow us to enable the COMDAT on ELF as well. |
|
lld sounds nice. :-) toolchains::Windows isn't a toolchains::GenericUnix, so this shouldn't matter there. |
This was referenced Nov 29, 2018
|
I agree, lld would be ideal, assuming it's mature enough and there aren't any showstopping bugs. We may however need to still maintain support for ld64 on Apple platforms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For all the same reasons outlined in PR #19875
AArch64 also needs to default to the "Gold" linker.