Skip to content

[5.0] Change Default Linker to Gold for AArch64 #20846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2018
Merged

[5.0] Change Default Linker to Gold for AArch64 #20846

merged 1 commit into from
Nov 29, 2018

Conversation

futurejones
Copy link
Contributor

Cherry-pick of: #20845
For all the same reasons outlined in PR #19875
AArch64 also needs to default to the "Gold" linker.

@futurejones futurejones requested a review from a team as a code owner November 28, 2018 23:43
@jrose-apple
Copy link
Contributor

👍

@swift-ci Please test

AnnaZaks
AnnaZaks approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@AnnaZaks AnnaZaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only affects Linux and simplifies lives of Linux users. The hope is to get AArch64 fully working in the 5.0 timeframe.

@AnnaZaks
Copy link
Contributor

Should not be merged right now and should wait for the convergence period to end (in a week or so).

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6d070c0

@jrose-apple
Copy link
Contributor

That's the second time that LLDB timeout has come up…

@swift-ci Please test macOS

This was referenced Nov 29, 2018
Closed
Merged
@tkremenek tkremenek merged commit 82e19dd into swiftlang:swift-5.0-branch Nov 29, 2018
@tkremenek tkremenek mentioned this pull request Nov 29, 2018
Merged
@tkremenek
Copy link
Member

I accidentally merged this too quickly, and reverted it in #20876.

This was marked pending-convergence for swift-5.0-branch. We can re-apply this change (by reverting #20876) once convergence of swift-5.0-branch has been lifted in the next couple weeks.

@tkremenek
Copy link
Member

PR to re-apply change: #20877

@AnthonyLatsis AnthonyLatsis added Linux Platform: Linux arm64 Architecture: arm64 (aarch64) — any 64-bit ARM and removed AArch64 Linux labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZaks AnnaZaks AnnaZaks approved these changes

Assignees
No one assigned
Labels
arm64 Architecture: arm64 (aarch64) — any 64-bit ARM Linux Platform: Linux pending convergence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@futurejones @jrose-apple @AnnaZaks @swift-ci @tkremenek @AnthonyLatsis