Skip to content

[5.0] SIMD into stdlib #20896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2018

Conversation

stephentyrone
Copy link
Contributor

Implements SE-0229.

Also updates simd module types in the Apple SDKs to use the new types, and updates a couple tests to work with the new types and protocols.

(cherry picked from commit fb8b9e1)

Resolves rdar://problem/17045503

Implements SE-0229.

Also updates simd module types in the Apple SDKs to use the new types, and updates a couple tests to work with the new types and protocols.

(cherry picked from commit fb8b9e1)
@stephentyrone stephentyrone requested a review from a team as a code owner November 30, 2018 01:31
@stephentyrone stephentyrone changed the title SIMD into stdlib [5.0] SIMD into stdlib Nov 30, 2018
@stephentyrone
Copy link
Contributor Author

@apple/swift5-branch-managers This is an ABI-impacting change for the SDK, because it changes the definition of the existing types in the simd module.

@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@stephentyrone
Copy link
Contributor Author

This will need to pick up #20914

)

* Move most of the simd operators into an optional module

Adding simd to the stdlib caused some typechecker regressions. We can resolve them in the near-term by making the types universally available, but moving the arithmetic operators into a separate module that must be explicitly imported.

* Move two fuzzing tests back to fixed.

* Add SIMDOperators as a dependency for MediaPlayer.

* Move the .-prefixed operator declarations back into the stdlib.

(cherry picked from commit 28962b5)
@stephentyrone
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a1fca9e

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a1fca9e

@airspeedswift airspeedswift merged commit b74d54a into swiftlang:swift-5.0-branch Dec 3, 2018
@stephentyrone stephentyrone deleted the simd-5.0 branch February 8, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants