Skip to content

[5.0] SIMD into stdlib #20896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions include/swift/Runtime/BuiltinTypes.def
Original file line number Diff line number Diff line change
Expand Up @@ -74,32 +74,43 @@ BUILTIN_VECTOR_TYPE(Bi16_, Int16, 4)
BUILTIN_VECTOR_TYPE(Bi16_, Int16, 8)
BUILTIN_VECTOR_TYPE(Bi16_, Int16, 16)
BUILTIN_VECTOR_TYPE(Bi16_, Int16, 32)
BUILTIN_VECTOR_TYPE(Bi16_, Int16, 64)

// Int32 vector types
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 2)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 3)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 4)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 8)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 16)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 32)
BUILTIN_VECTOR_TYPE(Bi32_, Int32, 64)

// Int64 vector types
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 2)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 3)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 4)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 8)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 16)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 32)
BUILTIN_VECTOR_TYPE(Bi64_, Int64, 64)

// Float32 vector types
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 2)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 3)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 4)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 8)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 16)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 32)
BUILTIN_VECTOR_TYPE(Bf32_, FPIEEE32, 64)

// Float64 vector types
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 2)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 3)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 4)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 8)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 16)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 32)
BUILTIN_VECTOR_TYPE(Bf64_, FPIEEE64, 64)

#undef BUILTIN_VECTOR_TYPE
#undef VECTOR_BUILTIN_SYMBOL_NAME
Expand Down
17 changes: 16 additions & 1 deletion lib/IRGen/GenClangType.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,7 @@ GenClangType::visitBoundGenericType(CanBoundGenericType type) {
AutoreleasingUnsafeMutablePointer,
Unmanaged,
CFunctionPointer,
SIMD,
} kind = llvm::StringSwitch<StructKind>(swiftStructDecl->getName().str())
.Case("UnsafeMutablePointer", StructKind::UnsafeMutablePointer)
.Case("UnsafePointer", StructKind::UnsafePointer)
Expand All @@ -461,6 +462,7 @@ GenClangType::visitBoundGenericType(CanBoundGenericType type) {
StructKind::AutoreleasingUnsafeMutablePointer)
.Case("Unmanaged", StructKind::Unmanaged)
.Case("CFunctionPointer", StructKind::CFunctionPointer)
.StartsWith("SIMD", StructKind::SIMD)
.Default(StructKind::Invalid);

auto args = type.getGenericArgs();
Expand All @@ -472,7 +474,7 @@ GenClangType::visitBoundGenericType(CanBoundGenericType type) {
case StructKind::Invalid:
llvm_unreachable("Unexpected non-pointer generic struct type in imported"
" Clang module!");

case StructKind::UnsafeMutablePointer:
case StructKind::Unmanaged:
case StructKind::AutoreleasingUnsafeMutablePointer: {
Expand All @@ -499,6 +501,19 @@ GenClangType::visitBoundGenericType(CanBoundGenericType type) {
auto fnPtrTy = clangCtx.getPointerType(functionTy);
return getCanonicalType(fnPtrTy);
}

case StructKind::SIMD: {
clang::QualType scalarTy = Converter.convert(IGM, loweredArgTy);
auto numEltsString = swiftStructDecl->getName().str();
numEltsString.consume_front("SIMD");
unsigned numElts;
bool failedParse = numEltsString.getAsInteger<unsigned>(10, numElts);
assert(!failedParse && "SIMD type name didn't end in count?");
(void) failedParse;
auto vectorTy = getClangASTContext().getVectorType(scalarTy, numElts,
clang::VectorType::VectorKind::GenericVector);
return getCanonicalType(vectorTy);
}
}

llvm_unreachable("Not a valid StructKind.");
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ if(SWIFT_BUILD_STDLIB)
add_subdirectory(runtime)
add_subdirectory(stubs)
add_subdirectory(core)
add_subdirectory(SIMDOperators)
add_subdirectory(SwiftOnoneSupport)
endif()

Expand Down
2 changes: 1 addition & 1 deletion stdlib/public/SDK/MediaPlayer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ add_swift_target_library(swiftMediaPlayer ${SWIFT_SDK_OVERLAY_LIBRARY_BUILD_TYPE
LINK_FLAGS "${SWIFT_RUNTIME_SWIFT_LINK_FLAGS}"
TARGET_SDKS IOS IOS_SIMULATOR

SWIFT_MODULE_DEPENDS_IOS Darwin AVFoundation CoreAudio CoreFoundation CoreGraphics CoreImage CoreMedia Dispatch Foundation Metal ObjectiveC QuartzCore simd UIKit os CoreData # auto-updated
SWIFT_MODULE_DEPENDS_IOS Darwin AVFoundation CoreAudio CoreFoundation CoreGraphics CoreImage CoreMedia Dispatch Foundation Metal ObjectiveC QuartzCore simd SIMDOperators UIKit os CoreData # auto-updated
FRAMEWORK_DEPENDS_WEAK MediaPlayer

DEPLOYMENT_VERSION_IOS ${SWIFTLIB_DEPLOYMENT_VERSION_MEDIAPLAYER_IOS}
Expand Down
8 changes: 4 additions & 4 deletions stdlib/public/SDK/SceneKit/SceneKit.swift.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ extension SCNVector3 {
}
}

extension float3 {
extension SIMD3 where Scalar == Float {
public init(_ v: SCNVector3) {
self.init(Float(v.x), Float(v.y), Float(v.z))
}
}

extension double3 {
extension SIMD3 where Scalar == Double {
public init(_ v: SCNVector3) {
self.init(Double(v.x), Double(v.y), Double(v.z))
}
Expand Down Expand Up @@ -86,13 +86,13 @@ extension SCNVector4 {
}
}

extension float4 {
extension SIMD4 where Scalar == Float {
public init(_ v: SCNVector4) {
self.init(Float(v.x), Float(v.y), Float(v.z), Float(v.w))
}
}

extension double4 {
extension SIMD4 where Scalar == Double {
public init(_ v: SCNVector4) {
self.init(Double(v.x), Double(v.y), Double(v.z), Double(v.w))
}
Expand Down
1 change: 1 addition & 0 deletions stdlib/public/SDK/simd/Quaternion.swift.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

import Swift
import Darwin
import SIMDOperators
@_exported import simd

%for scalar in ['Float','Double']:
Expand Down
Loading