add SILDeclRef modifier for autodiff functions #21224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test tensorflow |
slavapestov
approved these changes
Dec 11, 2018
| @@ -316,6 +316,14 @@ struct SILAutoDiffIndices { | |||
| [&s](unsigned p) { s << p; }, [&s]{ s << ' '; }); | |||
| s << "))"; | |||
| } | |||
|
|
|||
| std::string mangle() const { | |||
There was a problem hiding this comment.
Can you define a new AutoDiffMangler or similar, even if its still doing stuff like this? It will be easier to move to a real mangling in the future (which I encourage you to do).
There was a problem hiding this comment.
Kind of following the example in ASTMangler? I haven't read through that and understood how it works yet, but I'll do that and then implement something like it, in a later PR.
added 2 commits
December 11, 2018 16:20
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
marcrasi
added a commit
that referenced
this pull request
Dec 12, 2018
) This deletes the AutoDiffAssociatedFunctionWitness from the witness table, and instead puts the autodiff associated functions in normal method witness table entries, using the autodiff SILDeclRef from #21224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new field to SILDeclRef that modifies it to refer to an autodiff function that is associated with the original one. Adds printing/parsing for it. Uses the SILDeclRef to TBDGen a public symbol that the AD pass creates.
I want to remove the "autodiff" witness table entries and replace them with normal method witness table entries that use this SILDeclRef, but I will do that in a subsequent PR.
@slavapestov, @rjmccall: This is based on some discussion that I had with @rjmccall on Friday. There's a difference: I made a new field that "modifies" the meaning of the rest of the SILDeclRef, rather than a new kind of SILDeclRef. After having played with it a bit, it seems most natural to do it this way. (It's sort of a derivation path idea, I think?) I will probably merge this quite quickly to unblock some autodiff stuff that we are working on, but we can continue the discussion and I'll eventually come back and modify things to whatever we eventually come up with.