AutoDiff associated functions in witness table, using SILDeclRef #21241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Dec 12, 2018
| @@ -361,6 +361,13 @@ struct SILDeclRef { | |||
| return r; | |||
| } | |||
|
|
|||
| /// Returns this `SILDeclRef` with the `loc` replaced with `decl`. | |||
There was a problem hiding this comment.
Should this be SWIFT_ENABLE_TENSORFLOW?
There was a problem hiding this comment.
The pieces above it are tensorflow too, and they have a SWIFT_ENABLE_TENSORFLOW.
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow Linux CPU |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes the
AutoDiffAssociatedFunctionWitnessfrom the witness table, and instead puts the autodiff associated functions in normal method witness table entries, using the autodiff SILDeclRef from #21224.For easier reviewing, I have split it into two commits. The first commit removes most of the
AutoDiffAssociatedFunctionWitnessstuff, putting everything back mostly like it was inmaster, and the second commit adds the entries back in, using SILDeclRef.cc @slavapestov @rjmccall