[SourceKit][IDE] New SourceKit request to retrieve context type information #21377

rintaro · 2018-12-17T10:07:22Z

This is a new SourceKit request which receives a position in the source file, returns possible expected types and their members which can be referenced by "implicit member expression" syntax.

rdar://problem/44698136

benlangmuir · 2018-12-18T19:41:30Z

The name "context info" is fairly general; do you think "type context info" would work? Right now all the results are related to the semantic type of the context. On the other hand, if you foresee us adding non-type information here it might be misleading.

benlangmuir · 2018-12-18T19:46:49Z

tools/swift-ide-test/swift-ide-test.cpp

+  }
+  llvm::outs() << "found code completion token " << CodeCompletionToken
+               << " at offset " << Offset << "\n";
+  llvm::errs() << "found code completion token " << CodeCompletionToken


Huh, I wonder why we write this to both outs() and errs(). Seems silly. I guess it's fine to copy what code-completion does for now though.

Yeah, I just copied from code-completion code.
I believe outs() is for FileCheck and errs() is to see which test case failed from failure log.

rintaro · 2018-12-19T11:01:23Z

One possible enhancement in my mind is adding "kind" of context. Like

foo(x: #TOKEN#)  // -> call argument
return #TOKEN#   // -> return value
if #TOKEN# {     // -> statement condition

But I'm not sure it's valuable. And I think "type context info" still works even after adding it.
Let's change it to typecontextinfo.

Now that this passes all test cases we currently have. Stop analyzing outer contexts because it may emit invalid context type.

NFC

We don't need to keep ExprFinder beyond analysis.

Just refactoring. ExprContextInfo automatically construct analyzer and analyze().

Removed unnecessary arguments.

This replaces shouldHideDeclFromCompletionResults() in IDE.

NFC

TypeContextInfo is for new SourceKit request which receives source location, and returns context type and members which can be referenced by "implicit member expression" syntax. Implement that as a code completion callbacks.

rintaro · 2019-01-10T09:19:03Z

@swift-ci Please smoke test

This is a new SourceKit request which receives a position in the source file, returns possible expected types and their members which can be referenced by "implicit member expression" syntax.

rintaro · 2019-01-10T15:56:19Z

@swift-ci Please smoke test

rintaro · 2019-01-11T08:29:50Z

@benlangmuir @akyrtzi I think this PR is ready for reviewing.

benlangmuir · 2019-01-14T16:59:09Z

include/swift/AST/Decl.h

@@ -2412,6 +2412,10 @@ class ValueDecl : public Decl {

  bool isUsableFromInline() const;

+  /// Returns \c true if this declaration is *not* intended to be used directly
+  /// by application developers despite of the visibility.


"despite of" -> "despite", or "in spite of"

benlangmuir · 2019-01-14T17:07:18Z

lib/AST/Decl.cpp

@@ -2550,6 +2550,34 @@ bool ValueDecl::isUsableFromInline() const {
  return false;
 }

+/// Returns \c true if this declaration is *not* intended to be used directly
+/// by application developers despite of the visibility.


We don't usually copy doc comments to the definition since then we have two places to keep up to date separately.

benlangmuir · 2019-01-14T17:09:44Z

lib/IDE/CodeCompletion.cpp

@@ -2116,7 +2049,7 @@ class CompletionLookup final : public swift::VisibleDeclConsumer {
  void addVarDeclRef(const VarDecl *VD, DeclVisibilityKind Reason) {
    if (!VD->hasName() ||
        !VD->isAccessibleFrom(CurrDeclContext) ||
-        shouldHideDeclFromCompletionResults(VD))
+        VD->shouldHideFromEditor())


Is the function shouldHideDeclFromCompletionResults removed? I can't find it in this patch.

benlangmuir · 2019-01-14T17:11:11Z

lib/IDE/TypeContextInfo.cpp

+
+  // Ignore callbacks for suffix completions
+  // {
+  void completeDotExpr(Expr *E, SourceLoc DotLoc) override{};


Style: should have a space before {}.

benlangmuir · 2019-01-14T17:21:11Z

tools/SourceKit/lib/SwiftLang/SwiftTypeContextInfo.cpp

+  }
+  CI.performSema();
+
+  return true;


We should copy over the trace::TracedOperation code from code-completion as well so that this action shows up in compilation traces such as the Index Log.

rintaro requested a review from akyrtzi December 17, 2018 10:07

akyrtzi requested a review from benlangmuir December 18, 2018 01:21

benlangmuir reviewed Dec 18, 2018

View reviewed changes

rintaro force-pushed the ide-contextinfo branch from cb7f5ff to d71fac0 Compare December 20, 2018 01:57

rintaro force-pushed the ide-contextinfo branch from d71fac0 to d0df476 Compare January 9, 2019 07:44

rintaro added 10 commits January 10, 2019 17:52

[CodeCompletion] Only analyze inner most context

b033f48

Now that this passes all test cases we currently have. Stop analyzing outer contexts because it may emit invalid context type.

[IDE] Rename CodeCompletionTypeContextAnalyzer to ExprContextAnalyzer

2fb5425

NFC

[IDE] Refactor ExprContextAnalyzer. NFC

5c64324

We don't need to keep ExprFinder beyond analysis.

[IDE] Decouple ExprContextAnalyzer and ExprContextInfo

758ba5e

Just refactoring. ExprContextInfo automatically construct analyzer and analyze().

[IDE] ExprContextAnalyzer::Analyze() doesn't need to return success

e3387c6

[IDE] Rename collectArgumentExpectation() to analyzeApplyExpr()

867c28e

Removed unnecessary arguments.

[AST] Add shouldHideFromEditor() method

d17bb78

This replaces shouldHideDeclFromCompletionResults() in IDE.

[IDE] Move ExprContextAnalyser to its own file

2fbd3fe

NFC

[IDE] Move typeCheckContext() to ExprContextAnalysis.cpp

cc1d5c1

NFC

[IDE] Add TypeContextInfo callbacks to parser

54f0fab

TypeContextInfo is for new SourceKit request which receives source location, and returns context type and members which can be referenced by "implicit member expression" syntax. Implement that as a code completion callbacks.

rintaro force-pushed the ide-contextinfo branch from d0df476 to aa6d86b Compare January 10, 2019 09:18

rintaro changed the title ~~[WIP][SourceKit][IDE] New SourceKit request to retrieve context type information~~ [SourceKit][IDE] New SourceKit request to retrieve context type information Jan 10, 2019

[SourceKit] New request to retrieve context type information

3797b7a

This is a new SourceKit request which receives a position in the source file, returns possible expected types and their members which can be referenced by "implicit member expression" syntax.

rintaro force-pushed the ide-contextinfo branch from aa6d86b to 3797b7a Compare January 10, 2019 15:50

rintaro merged commit b446d6b into swiftlang:master Jan 14, 2019

benlangmuir reviewed Jan 14, 2019

View reviewed changes

rintaro mentioned this pull request Jan 23, 2019

[SourceKit][IDE] Update for feedback #22055

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SourceKit][IDE] New SourceKit request to retrieve context type information #21377

[SourceKit][IDE] New SourceKit request to retrieve context type information #21377

Uh oh!

rintaro commented Dec 17, 2018 •

edited

Loading

Uh oh!

benlangmuir commented Dec 18, 2018

Uh oh!

benlangmuir Dec 18, 2018

Uh oh!

rintaro Dec 19, 2018

Uh oh!

rintaro commented Dec 19, 2018

Uh oh!

rintaro commented Jan 10, 2019

Uh oh!

rintaro commented Jan 10, 2019

Uh oh!

rintaro commented Jan 11, 2019

Uh oh!

benlangmuir Jan 14, 2019

Uh oh!

benlangmuir Jan 14, 2019

Uh oh!

benlangmuir Jan 14, 2019

Uh oh!

benlangmuir Jan 14, 2019

Uh oh!

benlangmuir Jan 14, 2019

Uh oh!

Uh oh!

[SourceKit][IDE] New SourceKit request to retrieve context type information #21377

[SourceKit][IDE] New SourceKit request to retrieve context type information #21377

Uh oh!

Conversation

rintaro commented Dec 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benlangmuir commented Dec 18, 2018

Uh oh!

benlangmuir Dec 18, 2018

Choose a reason for hiding this comment

Uh oh!

rintaro Dec 19, 2018

Choose a reason for hiding this comment

Uh oh!

rintaro commented Dec 19, 2018

Uh oh!

rintaro commented Jan 10, 2019

Uh oh!

rintaro commented Jan 10, 2019

Uh oh!

rintaro commented Jan 11, 2019

Uh oh!

benlangmuir Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

benlangmuir Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

benlangmuir Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

benlangmuir Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

benlangmuir Jan 14, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rintaro commented Dec 17, 2018 •

edited

Loading