Skip to content

[SourceKit][IDE] Update for feedback #22055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2019
Merged

[SourceKit][IDE] Update for feedback #22055

merged 3 commits into from
Jan 24, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jan 23, 2019

Update for feedback on #21377 .

  • Update comment
  • Space between override and {}
  • Enable trace logging for typecontextinfo request

@rintaro rintaro requested a review from benlangmuir January 23, 2019 01:45
@rintaro
Copy link
Member Author

rintaro commented Jan 23, 2019

@swift-ci Please smoke test

@benlangmuir
Copy link
Contributor

Please add a basic test for the traced operation in swift/test/SourceKit/CompileNotifications. Otherwise LGTM, thanks!

@rintaro rintaro force-pushed the ide-contextinfo-suppliment branch from f5784a2 to 37bb049 Compare January 23, 2019 20:11
@rintaro
Copy link
Member Author

rintaro commented Jan 23, 2019

@swift-ci Please smoke test

@rintaro rintaro merged commit 16d97b2 into swiftlang:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @benlangmuir