Skip to content

[update-checkout] Add support to clone libcxx and clang-tools-extra f… #21389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2018

Conversation

shahmishal
Copy link
Member

…or master, master-next and swift-5.0-branch scheme

…or master, master-next and swift-5.0-branch scheme
@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal
Copy link
Member Author

@swift-ci smoke test Linux

@compnerd
Copy link
Member

@shahmishal - libc++ without libc++abi isn't that great of an idea. If you are going to add libc++, Id say you should add libc++abi as well.

@shahmishal
Copy link
Member Author

cc/ @dexonsmith @benlangmuir

@compnerd Thanks for pointing this out to me.

@benlangmuir
Copy link
Contributor

cc/ @ldionne

@dexonsmith
Copy link
Contributor

@shahmishal - libc++ without libc++abi isn't that great of an idea. If you are going to add libc++, Id say you should add libc++abi as well.

On Darwin, the libc++ headers are NOT in the SDK, and live along-side Clang. They are needed in order to create a working C++ toolchain. But the libc++abi headers are in the SDK, so they aren't needed here.

Perhaps installing the libc++ headers should be conditional on the platform (i.e., only on macOS)?

@compnerd
Copy link
Member

@shahmishal - oh if you are ensuring that libc++ is not built, then that is okay. But you can't really build libc++ without libc++abi (or libsupc++ or libcxxrt, but those paths aren't as well tested) or msvcrt.

@dexonsmith
Copy link
Contributor

Right, we're just looking to install libc++ headers here. Not trying to build libc++.1.dylib.

@shahmishal
Copy link
Member Author

@swift-ci smoke test Linux

@shahmishal shahmishal merged commit e575ae9 into master Dec 19, 2018
@shahmishal shahmishal deleted the add-swift-libcxx-and-swift-clang-tools-extra branch December 19, 2018 02:00
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants