-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Build and install 'clang' and 'clangd' in the macOS & linux toolchains #22184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci Please test |
Build failed |
@swift-ci build toolchain |
Build failed |
- Build script now builds clang_tools_extra as part of LLVM's build. - Build script now has a new libc++ build step to allow libc++ headers to be installed in the resulting toolchain. - 'clang', 'clangd', 'clang-headers' & 'compiler-rt' targets are now installed for the package build configurations for macOS and linux. - 'clang-resource-dir-symlink' is used in the package build configuration for macOS and linux to avoid duplication of Clang's headers and compiler-rt archives. rdar://24912710
Linux Toolchain (Ubuntu 16.04) Install command |
3ddec28
to
1941aaa
Compare
@swift-ci build toolchain |
@shahmishal I removed the clang driver tool line |
@swift-ci build toolchain |
Linux Toolchain (Ubuntu 16.04) Install command |
Hmm, does |
@swift-ci build toolchain macOS |
macOS Toolchain Install command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@swift-ci please smoke-test |
@swift-ci smoke test |
PRODUCTS=(cmark llvm) | ||
if [[ ! "${SKIP_BUILD_LIBCXX}" ]] ; then | ||
PRODUCTS=("${PRODUCTS[@]}" libcxx) | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I turned on --no-legacy-impl by default, this won't be enough. You need to add a Product
for libcxx in build-script
(the python code) so that this will be triggered. Right now it will be skipped by the check for $(should_execute_host_actions_for_phase ${host} build)
below.
resulting toolchain.
the package build configurations for macOS and linux.
to avoid duplication of Clang's headers and compiler-rt archives.
rdar://24912710