SILCombine: fix wrong placement of a strong_release of a dead closure argument which caused a memory leak #21391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… argument which caused a memory leak The code to find the release-points didn't handle release_value instructions. https://bugs.swift.org/browse/SR-9518 rdar://problem/46794455
|
@swift-ci test |
gottesmm
approved these changes
Dec 18, 2018
|
As a rule, I would say that opcode lists should never appear in /SILOptimizer unless they are part of a bailout or guarded by that bailout with assertions. There should be one place in /SIL that associates opcodes with a SIL property. |
|
Build failed |
|
@swift-ci smoke test linux |
1 similar comment
|
@swift-ci smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to find the release-points didn't handle release_value instructions.
https://bugs.swift.org/browse/SR-9518
rdar://problem/46794455