Skip to content

[5.0][stdlib] tee _stdlib_AtomicInt > SwiftPrivate #21434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 21, 2018

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Dec 19, 2018

5.0 version of #21337

@moiseev moiseev requested a review from a team as a code owner December 19, 2018 18:08
@moiseev
Copy link
Contributor Author

moiseev commented Dec 19, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c1a907b628dd17e9ba0ae7b3fcae0948dda04ef3

Turns out some people used this type despite it being prefixed with
`_stdlib_`, so we have to keep it, with an obsoletion message this time.
Second copy of the same type is kept available past Swift 5 in
SwiftPrivate for use in tests.

(cherry picked from commit 165fe32)
(cherry picked from commit 1f5c0f8)
@moiseev moiseev force-pushed the atomic-int-reshuffle-5 branch from c1a907b to 113b7a5 Compare December 19, 2018 21:35
@moiseev
Copy link
Contributor Author

moiseev commented Dec 19, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c1a907b628dd17e9ba0ae7b3fcae0948dda04ef3

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c1a907b628dd17e9ba0ae7b3fcae0948dda04ef3

@moiseev
Copy link
Contributor Author

moiseev commented Dec 20, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 113b7a5

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 113b7a5

@moiseev
Copy link
Contributor Author

moiseev commented Dec 20, 2018

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ee34dc1

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ee34dc1

@moiseev
Copy link
Contributor Author

moiseev commented Dec 21, 2018

@swift-ci Please test

@najacque najacque merged commit 2e6ed71 into swiftlang:swift-5.0-branch Dec 21, 2018
@moiseev moiseev deleted the atomic-int-reshuffle-5 branch December 21, 2018 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants