[benchmark] Fix: random fail Benchmark_O.test.md #21459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the two measured samples from `Ackermann` happen to have the exact same value, the delta compression produces a comma instead of number. Accept both forms. https://bugs.swift.org/browse/SR-9544
|
@swift-ci please test |
|
@eeckstein Please review 🙏 In my local tests the simplified ERE from second commit seems to work, too. Can you please verify that what I wrote actually means "accept either a comma or series of numbers"? |
eeckstein
approved these changes
Dec 20, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci please test |
|
Ah, your regex means what you said, but it's not what you actually want. The pattern you want is |
|
Oh, you are right! The number of commas doesn't change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the two measured samples from
Ackermannhappen to have the exact same value, the delta compression produces a comma instead of a number. Accept both forms.Resolves SR-9544.