Always set the compatibility_version of linked dylibs on Darwin. #21890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 1.0.0 when there is no more-specific SWIFT_COMPILER_VERSION.
|
@swift-ci please test |
|
Is the default 0.0.0 not good enough? |
With 0.0.0, I've had trouble getting the dynamic linker to accept a just-built dylib in place of one that shipped with the compiler. Having the 1.0.0 compatibility version works around that; it only affects development compilers we build ourselves. |
|
@DougGregor this looks ok to me. We may want to check with @Rostepher, @shahmishal, and @zisko if there are any impacts on other stuff. |
|
"Official" builds of Swift always have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 1.0.0 when there is no more-specific SWIFT_COMPILER_VERSION.