Skip to content

[Build System: CMake] Always set the dyld compatibility_version of linked dylibs on Darwin platforms (5.0). #22832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2019
Merged

[Build System: CMake] Always set the dyld compatibility_version of linked dylibs on Darwin platforms (5.0). #22832

merged 1 commit into from
Feb 25, 2019

Conversation

Rostepher
Copy link
Contributor

This is a cherry-pick of #21890 for the 5.0 branch.

rdar://48023939

@DougGregor
Always set the compatibility_version of linked dylibs on Darwin.
252ac2b 
Use 1.0.0 when there is no more-specific SWIFT_COMPILER_VERSION.

(cherry picked from commit 00485af)
@Rostepher Rostepher added the bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. label Feb 22, 2019
@Rostepher Rostepher self-assigned this Feb 22, 2019
@Rostepher Rostepher requested a review from DougGregor February 22, 2019 22:58
@Rostepher Rostepher requested a review from a team as a code owner February 22, 2019 22:58
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@shahmishal
Copy link
Member

@swift-ci build toolchain macOS

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - 252ac2b

Install command
tar -zxf swift-PR-22832-212-osx.tar.gz --directory ~/

bob-wilson
bob-wilson approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bob-wilson bob-wilson merged commit 4e893ec into swiftlang:swift-5.0-branch Feb 25, 2019
@Rostepher Rostepher deleted the dyld-compatibility-version-5.0 branch February 25, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bob-wilson bob-wilson bob-wilson approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees

@Rostepher Rostepher

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rostepher @shahmishal @swift-ci @bob-wilson @DougGregor