[Remote AST] Resolve extension context descriptors to demangle trees. #22150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read the extended context mangled name from an extension context descriptor so we can form a proper demangle tree for extensions. For example, this allows types nested within extensions of types from different modules to be found.
|
More for @dcci to get excited about ;) |
|
@swift-ci please smoke test |
Protocol references are interesting because we have to deal with the low bit indicating whether we have a reference to an Objective-C protocol. Factor out this logic for later re-use.
When reading a mangled name, make sure to cope with embedded null bytes that show up in symbolic references. When demangling such a name, handle symbolic references.
Translate the metadata for the generic requirements of an extension context into a demangle tree that is associated with the demangling of an extension. Teach the ASTDemangler how to handle class layout constraints as well. With this, RemoteAST can resolve types nested within most constrained extensions.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
Build failed |
|
Build failed |
… rather than clearing it out completely. This is better hygiene, although it doesn’t matter right now.
The “string length” primitive was validating the string data as valid UTF-8 to get the length. However, mangled names, which get read by this operation, are not always valid UTF-8. Just count the bytes until a ‘0’ and don’t validate.
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test and merge |
|
The failure on the simulator is unrelated. |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the extended context mangled name from an extension context descriptor
so we can form a proper demangle tree for extensions. For example, this allows
types nested within extensions of types from different modules to be found, as
well as finding types defined within constrained extensions.