Skip to content

Remote: use the qualified name for NodePointer #22155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Remote: use the qualified name for NodePointer #22155

merged 1 commit into from
Jan 28, 2019

Conversation

compnerd
Copy link
Member

Use the qualified name for the NodePointer. The unqualified name
causes ambiguity when building on Windows. This repairs the Windows
build.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Remote: use the qualified name for NodePointer
e8c6e84 
Use the qualified name for the `NodePointer`.  The unqualified name
causes ambiguity when building on Windows.  This repairs the Windows
build.
@compnerd
Copy link
Member Author

@DougGregor 61d14ed broke the windows build :-( https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=176

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e8c6e84

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e8c6e84

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e8c6e84

@compnerd
Copy link
Member Author

@swift-ci please test macOS platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e8c6e84

@DougGregor
Copy link
Member

Ugh, I probably did this more times in #22150

@compnerd
Copy link
Member Author

@DougGregor fun times! You hit the same thing that I'm hitting the iOS simulator issue. I'm going to put up a disabling change for that test. I'll try to run through that patch and see if it hits any ambiguity.

@DougGregor
Copy link
Member

@compnerd Thank you! Note that smoke testing will dodge the TypeDecoder failure; thanks for opening a PR to disable while @slavapestov fixes it.

I can speculatively qualify the NodePointer uses in that file, if it would help you, but I don't have a Windows environment set up to test with MSVC right now.

@compnerd
Copy link
Member Author

Actually, the swift builds are building with clang-cl atm because building with cl breaks down with some of the co-routine stuff :-(. Need to figure out how to get that repaired so that we keep the host tools portable. But, yeah, if you can speculatively qualify the NodePointer that would be helpful.

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd compnerd merged commit b422fdc into swiftlang:master Jan 28, 2019
@compnerd compnerd deleted the NodePointer branch January 28, 2019 18:57
@compnerd compnerd mentioned this pull request Jan 28, 2019
Merged
@compnerd
Copy link
Member Author

@DougGregor : https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compnerd @swift-ci @DougGregor