Move an ineffective variable initialization to a where is has an effect #22623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original location was only invoked when build-script invked cmake and on top of that it did not actually make it into the cmake command line. Since build-script is running lit manually anyway, we can just move it over there.
adrian-prantl
force-pushed
the
asanthreads
branch
from
4130512 to
1fa23a6
Compare
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original location was only invoked when build-script invked cmake
and on top of that it did not actually make it into the cmake command
line. Since build-script is running lit manually anyway, we can just
move it over there.