Skip to content

[benchmark] Move fake autoreleasepool to TestUtils #22707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

palimondo
Copy link
Contributor

This workaround for writing cross platform benchmarks originally introduced by @gottesmm in #21905 is required in multiple performance tests.

Undeclared autoreleasepool was the reason for failing linux smoke test on #22648 during swiftpm compilation of benchmarks. This should fix it.

This workaround for writing cross platform benchmarks is required in multiple performance tests.
@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@eeckstein @gottesmm Please review 🙏

@swift-ci
Copy link
Contributor

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
Breadcrumbs.CopyUTF16CodeUnits.Mixed 58 64 +10.3% 0.91x (?)

Performance: -Onone

TEST OLD NEW DELTA RATIO
Improvement
ObjectiveCBridgeStubFromNSString 986 915 -7.2% 1.08x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@ianpartridge
Copy link
Contributor

Looks good to me - thanks @palimondo.

@gottesmm
Copy link
Contributor

LGTM

@ianpartridge
Copy link
Contributor

Can we merge this to unblock #22648?

@palimondo palimondo merged commit 40cce2d into swiftlang:master Feb 20, 2019
@palimondo palimondo deleted the within-one-stem branch May 6, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants