Skip to content

Continue plumbing resilience expansion through SIL type lowering #23004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 1, 2019
Merged

Continue plumbing resilience expansion through SIL type lowering #23004

merged 8 commits into from
Mar 1, 2019

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov force-pushed the sil-resilience-expansion-plumbing branch from 1f39128 to b627eb1 Compare March 1, 2019 02:22
@slavapestov
SIL: Optimization remarks can take SILType by value
c970cae 
No need to pass a pointer to SILType; it is a pointer-sized value itself.
@slavapestov
SILOptimizer: Small cleanups for devirtualizer
112d1bd 
Where possible, pass around a ClassDecl or a CanType instead of a
SILType that might wrap a metatype; the unwrapping logic was
repeated in several places.

Also add a FIXME for a bug I found by inspection.
@slavapestov
SILOptimizer: Remove isSimpleType()
c5cf5c2 
This was checking if the type is a trivial type that is not a
class. However this was redundant because class types are not
trivial anyway.
@slavapestov
SIL: Add type lowering APIs to SILFunction
d1cf8c9 
For now these just forward to methods on the module's TypeLowering,
but soon they will use the SILFunction's resilience expansion.
@slavapestov
SIL: Use SILFunction type lowering APIs in various places
1944254
@slavapestov
SIL: Remove SILType::getReferentType()
2970334
@slavapestov
SIL: Remove SILType::getMetatypeInstanceType()
903721c
@slavapestov
SIL: Add resilience expansion parameter to SILModule::isTypeABIAccess…
a9841e8 
…ible()
@slavapestov slavapestov force-pushed the sil-resilience-expansion-plumbing branch from b627eb1 to a9841e8 Compare March 1, 2019 07:15
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov merged commit 7b0d10e into swiftlang:master Mar 1, 2019
@slavapestov slavapestov mentioned this pull request Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slavapestov