SIL: Remove default arguments from resilience expansion parameters #23110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eeckstein you should probably take a look at this PR, #23082 and #23004 |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
We want to be sure to only use types lowerered with ResilienceExpansion::Minimal when computing function signatures.
…owerChildren() NFC for now.
Each call site will soon have to think about passing in the right expansion instead of just assuming the default will be OK. But there are now only a few call sites left, because most have been refactored to use convenience APIs that pass in the right resilience expansion already.
slavapestov
force-pushed
the
resilience-expansion-has-no-default
branch
from
071147c to
d04c335
Compare
|
apple/swift-lldb#1353 |
|
@swift-ci Please test source compatibility |
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concludes the first phase of a refactoring. Previous PRs include:
The next step is to look at each occurrence of
FIXME: Expansionand pass in the right expansion.https://bugs.swift.org/browse/SR-261, rdar://24057844