More resilience expansion plumbing for type lowering #23126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pansions When calling getTypeLowering() for the first time with a new type that did not appear in the cache under _any_ resilience expansion, we would incorrectly take the unlowered type and treat it as a lowered type, incorrectly skipping the computeLoweredRValueType() call.
We were calling isResilent() to check if a type's layout contained a type that was resilient in some resilience domain. This was used to determine if we should re-lower the type when the desired resilience expansion does not match the given resilence expansion. However this bit was only getting set on address only types. This means if a resilient type was lowered with maximal expansion first, and this produced a non-address only type lowering, we would not lower it again when minimal expansion was requested. This can't be triggered with the existing tests, but upcoming changes result in regressions from this.
slavapestov
force-pushed
the
begin-removing-fixme-expansions
branch
2 times, most recently
from
3a2d24d to
268f780
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
eeckstein
approved these changes
Mar 6, 2019
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #23110, I've started fixing the call sites annotated with
// FIXME: Expansion. This uncovered some more type lowering bugs and missing APIs.rdar://problem/24057844, https://bugs.swift.org/browse/SR-261.