Skip to content

Test that initializers inherit '@objc' from convenience inits #23305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions test/attr/attr_objc_swift4.swift
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// RUN: %target-swift-frontend -disable-objc-attr-requires-foundation-module -typecheck -verify %s -swift-version 4 -enable-source-import -I %S/Inputs
// RUN: %target-swift-ide-test -skip-deinit=false -print-ast-typechecked -source-filename %s -prefer-type-repr=false -print-implicit-attrs=true -explode-pattern-binding-decls=true -disable-objc-attr-requires-foundation-module -swift-version 4 -enable-source-import -I %S/Inputs | %FileCheck %s
// REQUIRES: objc_interop

import Foundation
Expand Down Expand Up @@ -30,3 +31,42 @@ class BadInSwift4 {
@GKInspectable var badGKInspectable: PlainStruct?
// expected-error@-1{{property cannot be marked @GKInspectable because its type cannot be represented in Objective-C}}
}

// CHECK-LABEL: class InitsInheritObjCAttrBase
class InitsInheritObjCAttrBase: NSObject {
override init() {}
// CHECK: {{^}} @objc convenience init(foo: Int)
@objc convenience init(foo: Int) { self.init() }
} // CHECK: {{^[}]$}}

// CHECK-LABEL: extension InitsInheritObjCAttrBase
extension InitsInheritObjCAttrBase {
// CHECK: {{^}} @objc convenience dynamic init(bar: Int)
@objc convenience init(bar: Int) { self.init() }
} // CHECK: {{^[}]$}}

// CHECK-LABEL: class ConvenienceInitsInheritObjCAttrSub
class ConvenienceInitsInheritObjCAttrSub: InitsInheritObjCAttrBase {
init(somethingElse: ()) { super.init() }

// CHECK: {{^}} @objc convenience init(foo: Int)
convenience init(foo: Int) { self.init(somethingElse: ()) }
// FIXME: The '@objc' is relied upon, but the 'dynamic' probably shouldn't be!
// CHECK: {{^}} @objc convenience dynamic init(bar: Int)
convenience init(bar: Int) { self.init(somethingElse: ()) }

// CHECK: {{^}} convenience init(unrelated: Int)
convenience init(unrelated: Int) { self.init(somethingElse: ()) }
} // CHECK: {{^[}]$}}

// CHECK-LABEL: class DesignatedInitsInheritObjCAttrSub
class DesignatedInitsInheritObjCAttrSub: InitsInheritObjCAttrBase {
// CHECK: {{^}} @objc init(foo: Int)
init(foo: Int) { super.init() }
// FIXME: The '@objc' is relied upon, but the 'dynamic' probably shouldn't be!
// CHECK: {{^}} @objc dynamic init(bar: Int)
init(bar: Int) { super.init() }

// CHECK: {{^}} init(unrelated: Int)
init(unrelated: Int) { super.init() }
} // CHECK: {{^[}]$}}