Skip to content

[Runtime] Android does not support constexpr #2345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2016
Merged

[Runtime] Android does not support constexpr #2345

merged 1 commit into from
Apr 29, 2016

Conversation

modocache
Copy link
Contributor

What's in this pull request?

As with Cygwin, Android must not use constexpr for pthread initializers.

This fixes the Android build.

Resolved bug number: None

Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@modocache
[Runtime] Android does not support constexpr
66c4c87 
As with Cygwin, Android must not use `constexpr` for pthread
initializers.
@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 0d9063f into swiftlang:master Apr 29, 2016
@modocache modocache deleted the android-constexpr-fix branch April 30, 2016 20:32
MaxDesiatov pushed a commit that referenced this pull request Apr 19, 2021
@pull
Merge pull request #2345 from swiftwasm/main
4c26b26 
[pull] swiftwasm from main
@drodriguez drodriguez mentioned this pull request Jul 29, 2021
Merged
drodriguez added a commit that referenced this pull request Aug 2, 2021
@drodriguez
[android] Android seems to support constexpr mutex with NDK 19c (at l…
a8bb9ff 
…east) (#38686)

The usage of constexpr was disabled in 2016 in #2345, but using NDK 19c,
it seems that the usage doesn't fail compiling at the moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@modocache @gribozavr @swift-ci