[android] Android seems to support constexpr mutex with NDK 19c (at least) #38686
Conversation
…east) The usage of constexpr was disabled in 2016 in swiftlang#2345, but using NDK 19c, it seems that the usage doesn't fail compiling at the moment.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
I'll try it out natively on Android and let you know. |
There was a problem hiding this comment.
I applied this pull to the July 30 trunk source snapshot and then built and ran the compiler validation suite natively on my Android 11 phone with the Termux packages of clang 12 and the NDK 21d sysroot: there was only one BuildSystem test regression since my previous test run with the July 6 trunk snapshot, which doesn't even touch this Runtime code and is unrelated.
Everything appears to be good, I will build out the rest of the toolchain natively on Android 11 now and run all their tests, but I don't expect anything to turn up.
|
Finished building and testing the toolchain on Android AArch64, no problem. |
The usage of constexpr was disabled in 2016 in #2345, but using NDK 19c,
it seems that the usage doesn't fail compiling at the moment.
The Android CI started failing after the introduction of #38562. Using constexpr seems to avoid the problem.
@buttaface: do you mind looking at this and maybe checking that the runtime is not completely broken (I tested with the compiler itself, but I have no way of testing the runtime at the moment).