[Runtime] Static constructors and destructors should be an error here. #38562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Except for a handful of places we know about, there should be no static constructors or destructors in the runtime; they're undesirable because they inflate start up or shut down times, and in the case of destructors we can't even guarantee that they will actually run (e.g. if the program declares that it supports fast termination, they just won't). It should be OK to change the warnings to errors as a result. rdar://80965245
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS platform |
|
LGTM. @compnerd any pitfalls with this that we might not have thought of? |
mikeash
approved these changes
Jul 22, 2021
|
@swift-ci Please smoke test macOS platform |
1 similar comment
|
@swift-ci Please smoke test macOS platform |
|
This might need to be gated by platform somehow. There are some platforms (Cygwin, Android, Haiku, Wasi) that do not support mutexes without destructors. I think I might have "fixed" Android in #38686, but the other platforms might still fail. |
|
Unfortunate. Can we disable the warnings/errors at the specific point of use on those platforms? |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jul 30, 2021
Replace the `static std::mutex` with Swift's `StaticMutex` so that we avoid triggering an error due to an exit time destructor. Repairs the build after swiftlang#38562.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except for a handful of places we know about, there should be no static constructors or destructors in the runtime; they're undesirable because they inflate start up or shut down times, and in the case of destructors we can't even guarantee that they will actually run (e.g. if the program declares that it supports fast termination, they just won't).
It should be OK to change the warnings to errors as a result.
rdar://80965245