Skip to content

runtime: replace use of std::mutex with StaticMutex #38698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2021
Merged

runtime: replace use of std::mutex with StaticMutex #38698

merged 1 commit into from
Jul 30, 2021

Conversation

compnerd
Copy link
Member

Replace the static std::mutex with Swift's StaticMutex so that we
avoid triggering an error due to an exit time destructor. Repairs the
build after #38562.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd
Copy link
Member Author

CC: @mikeash @al45tair

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4e20efb5a7f9c9ab06ac60c7f86d9dfadb198d1f

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4e20efb5a7f9c9ab06ac60c7f86d9dfadb198d1f

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 4e20efb5a7f9c9ab06ac60c7f86d9dfadb198d1f

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4e20efb5a7f9c9ab06ac60c7f86d9dfadb198d1f

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test macOS platform

@compnerd
Copy link
Member Author

@swift-ci please smoke test Linux platform

@compnerd
Copy link
Member Author

@swift-ci please clean test Linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 4e20efb5a7f9c9ab06ac60c7f86d9dfadb198d1f

al45tair
al45tair reviewed Jul 30, 2021
View reviewed changes
@compnerd
runtime: replace use of std::mutex with StaticMutex
6c50325 
Replace the `static std::mutex` with Swift's `StaticMutex` so that we
avoid triggering an error due to an exit time destructor.  Repairs the
build after swiftlang#38562.
@compnerd
Copy link
Member Author

@swift-ci please test

@compnerd compnerd merged commit 21405d8 into swiftlang:main Jul 30, 2021
@compnerd compnerd deleted the static-mutex branch July 30, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@al45tair al45tair al45tair left review comments

@mikeash mikeash mikeash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@compnerd @swift-ci @mikeash @al45tair