[5.1][CodeCompletion] Grab bag of recent changes in code completion #23577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a type conditionally conforms to a protocol, it used to provide
symbols from extension to that protocol.
e.g.:
protocol P {}
extension P {
func foo() {}
}
struct S<T> {}
extension S: P where T == Int {}
func test(val: S<String>) {
val.#^COMPLETE^#
}
This should not provide `foo()` method.
rdar://problem/36594731
(cherry picked from commit dcb1db2)
There should be escaped identifiers in code completion: - As primary expression: Any keyword name except for `self` and `Self`. - After dot: Something named `init`. rdar://problem/16232627 (cherry picked from commit df473f6)
rdar://problem/36818556 (cherry picked from commit 3e4ab1f)
'init?()' and 'init()' are considerd conflicting. But user can declare both if only one of them is available. rdar://problem/47408946 (cherry picked from commit c01799c)
rdar://problem/35943849 (cherry picked from commit fd542e2)
The parsed expression may be wrapped with various implicit expressions. For example, if the expression is only element in array literal, it's wrapped with `(arrayLiteral: <expr>)`. (cherry picked from commit bfaa6af)
This improves discoverability of no-parameter initializers. rdar://problem/46215262 (cherry picked from commit 7ae18ff)
…context For unresolved member completion, member decls in `Optional` referenceable by implicit member expression are useless in most cases. - `init(_: <#Wrapped#>)` - `init(nilLiteral: ())` - `.some(<#Wrapped#>)` - `.none` Instead, provide `nil` with erasing `.` instruction. rdar://problem/47806831 (cherry picked from commit 7e3a5dc)
with "TODO: ignore them in expression context". They are useful in pattern context, so we should provide them in completion. (cherry picked from commit b1efc21)
So that this works:
```
func foo(_: KeyPath<SomeObject, Int>) {}
foo(\.<HERE>)
```
rdar://problem/46102807
(cherry picked from commit 65d8d29)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of recent changes in code-completion for
swift-5.1-branch