Skip to content

Update checkout for TensorFlow repos. #23700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 7, 2019
Merged

Update checkout for TensorFlow repos. #23700

merged 7 commits into from
Apr 7, 2019

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 31, 2019 •
edited
Loading

@rxwei rxwei added the tensorflow This is for "tensorflow" branch PRs. label Mar 31, 2019
@rxwei
Copy link
Contributor Author

rxwei commented Mar 31, 2019

@swift-ci please clean test tensorflow

@rxwei rxwei requested a review from dan-zheng March 31, 2019 22:08
@rxwei
Copy link
Contributor Author

rxwei commented Mar 31, 2019

@swift-ci please clean test tensorflow macOS

@rxwei rxwei mentioned this pull request Mar 31, 2019
Merged
@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

2 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow linux

@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 1, 2019

@swift-ci please clean test tensorflow

@rxwei rxwei mentioned this pull request Apr 1, 2019
Merged
@eaplatanios
Copy link

@rxwei the failures were fixed in my latest commit here.

@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

Can you fix them in a separate patch? The PR description says "This is a work-in-progress PR that also depends on the advanced indexing PR". Since it's depends on other changes that have not been merged, we cannot merge it.

@rxwei rxwei mentioned this pull request Apr 2, 2019
Merged
@rxwei rxwei changed the title Update checkout for 'tensorflow/swift-apis' and 'tensorflow/swift-bindings' Update checkout for TensorFlow repos. Apr 2, 2019
@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

@swift-ci please clean test tensorflow

2 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

@swift-ci please clean test tensorflow macOS

@rxwei
Copy link
Contributor Author

rxwei commented Apr 2, 2019

@eaplatanios This is still not compiling for some reason.

@eaplatanios eaplatanios mentioned this pull request Apr 3, 2019
Merged
@eaplatanios
Copy link

There were some more issues. Apparently there are two padding types now. It should have been fixed here, but we may be able to improve the API by also adding support for explicit paddings to the pooling ops.

@eaplatanios
Copy link

@rxwei This should compile fine after this PR is merged.

@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow Linux GPU

1 similar comment
@rxwei
Copy link
Contributor Author

rxwei commented Apr 3, 2019

@swift-ci please clean test tensorflow Linux GPU

@eaplatanios
Copy link

@rxwei There seem to be some test failures in the CI, but I can't currently access the CI web interface for some reason and have no idea what fails.

@eaplatanios
Copy link

@rxwei now I am able to access the failures. It seems that some tests are checking what ops get added to a TF graph and they are using the Conv2D op. Since the op now has an extra attribute, these fail. Since I cannot make edits to this PR, could you please fix those?

@dan-zheng
Copy link
Contributor

I'll look into fixing the failures now. It seems to be a matter of updating test cases.

@dan-zheng
Fix tests.
9f277e7 
Add `explicit_paddings` Conv2D attribute.
@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow

@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow linux

@rxwei rxwei mentioned this pull request Apr 7, 2019
Closed
@brettkoonce
Copy link
Contributor

🍕

@rxwei
Copy link
Contributor Author

rxwei commented Apr 7, 2019

@swift-ci please test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Apr 7, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 7, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Apr 7, 2019

@swift-ci please test tensorflow

@dan-zheng
Copy link
Contributor

All tests finally pass! Merging.
cc @eaplatanios, FYI in case this unblocks some of your work

@dan-zheng dan-zheng merged commit a0a9c9a into tensorflow Apr 7, 2019
@dan-zheng dan-zheng deleted the rxwei-patch-3 branch April 7, 2019 04:27
rxwei added a commit to rxwei/swift that referenced this pull request May 11, 2019
@rxwei
Update checkout for TensorFlow repos. (swiftlang#23700)
ee6b966 
* Update checkout for 'tensorflow/swift-apis' and 'tensorflow/swift-bindings'.

* tensorflow/tensorflow@5e8df78
* tensorflow/swift-bindings@0957744
* tensorflow/swift-apis@18f9371
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
tensorflow This is for "tensorflow" branch PRs. update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rxwei @eaplatanios @dan-zheng @brettkoonce @AnthonyLatsis