Added a filter for ops with ref-valued inputs that are not supported. #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-valued inputs that are not supported.
…50b4ed with PR #27327 on top of it.
Since this contains some change that hasn't been merged yet, we should wait for it to merge first. |
|
@rxwei Sounds good! I removed the unmerged op. The generated module now contains everything from core TF repo commit 5e8df789cc30098d791475c14a623ec68b50b4ed. |
|
Great. Thanks. |
rxwei
reviewed
Mar 31, 2019
| @@ -2130,7 +1451,7 @@ public static func avgPool<T: FloatingPoint & TensorFlowScalar>( | |||
| ksize: [Int32], | |||
| strides: [Int32], | |||
| padding: Padding, | |||
| dataFormat: DataFormat = .nhwc | |||
| dataFormat: DataFormat = .b'nhwc' | |||
There was a problem hiding this comment.
@eaplatanios This is malformed and causing swiftlang/swift#23700 to fail. I'm going to revert this PR for now.
There was a problem hiding this comment.
Oh I know why this happens. It’s a Python 3 compatibility bug. I’ll fix it once I get to my laptop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
The last one generates a large diff and not sure if it break compatibility with anything. Should I split it out as a separate PR?