[android] Make ADB push use sync if available. #24146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In recent adb versions, the push command supports a new option --sync which performs checksumming of the files to transmit against the files already in the device. This increases the effective transmission speed of the inital step in the test for Android. It should not affect the speed of each tests, since they are pushed to different folders, and also they are removed when they are successful. However, the test executables are small compared to the size of the libraries from the stadard library and dependencies. This should exclusively affect Android and only to people testing the executable tests (not CI).
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
drodriguez
added a commit
to drodriguez/swift
that referenced
this pull request
May 7, 2019
In normal cases, adb_clean.py cleaning the temporal directory is a good idea because all the tests run in a clean state, and previous executions do not influence the current one. However, when iterating and running only one or two tests with utils/run-test, removing all the artifacts and uploading them to the device can turn each iteration into waiting a couple of minutes. Since the changes in between tests should only touch a couple of libraries (or none at all, if the test itself is the modification), avoiding a full clean is beneficial. The commit modifies `adb_clean.py` to allow providing the environment variable `SKIP_ANDROID_CLEAN`, which will simply not execute the script. Since the introduction of swiftlang#24146, only the modified artifacts will be uploaded, and the test iteration can be very fast (including no time, if there are no changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent adb versions, the push command supports a new option --sync
which performs checksumming of the files to transmit against the files
already in the device. This increases the effective transmission speed
of the inital step in the test for Android.
It should not affect the speed of each tests, since they are pushed to
different folders, and also they are removed when they are successful.
However, the test executables are small compared to the size of the
libraries from the stadard library and dependencies.
This should exclusively affect Android and only to people testing the
executable tests (not CI).