[android] Allow skipping adb_clean.py #24551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In normal cases, adb_clean.py cleaning the temporal directory is a good idea because all the tests run in a clean state, and previous executions do not influence the current one. However, when iterating and running only one or two tests with utils/run-test, removing all the artifacts and uploading them to the device can turn each iteration into waiting a couple of minutes. Since the changes in between tests should only touch a couple of libraries (or none at all, if the test itself is the modification), avoiding a full clean is beneficial. The commit modifies `adb_clean.py` to allow providing the environment variable `SKIP_ANDROID_CLEAN`, which will simply not execute the script. Since the introduction of swiftlang#24146, only the modified artifacts will be uploaded, and the test iteration can be very fast (including no time, if there are no changes).
compnerd
approved these changes
May 7, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In normal cases, adb_clean.py cleaning the temporary directory is a good
idea because all the tests run in a clean state, and previous executions
do not influence the current one.
However, when iterating and running only one or two tests with
utils/run-test, removing all the artifacts and uploading them to the
device can turn each iteration into waiting a couple of minutes. Since
the changes in between tests should only touch a couple of libraries (or
none at all, if the test itself is the modification), avoiding a full
clean is beneficial.
The commit modifies
adb_clean.pyto allow providing the environmentvariable
SKIP_ANDROID_CLEAN, which will simply not execute the script.Since the introduction of #24146, only the modified
artifacts will be uploaded, and the test iteration can be very fast
(including no time, if there are no changes).