IRGen: do not use WeakImport on PE/COFF
#24263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PE/COFF does not provide weak import semantics. Fallback to strong import semantics on PE/COFF.
|
@swift-ci please test |
|
I guess we're not planning to use that sort of backwards-deployment model for PE/COFF anyway, but we might need an alternative at some point. (Or maybe we'll be able to eliminate |
|
Thanks, @compnerd. I'll pull this over to the 5.1 and 5.1-04-24 branches, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PE/COFF does not provide weak import semantics. Fallback to strong
import semantics on PE/COFF.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.