Skip to content

IRGen: do not use WeakImport on PE/COFF #24273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2019
Merged

IRGen: do not use WeakImport on PE/COFF #24273

merged 1 commit into from
Apr 25, 2019

Conversation

bob-wilson
Copy link
Contributor

PE/COFF does not provide weak import semantics. Fallback to strong
import semantics on PE/COFF.

@compnerd @bob-wilson
IRGen: do not use WeakImport on PE/COFF
962aa8c 
PE/COFF does not provide weak import semantics.  Fallback to strong
import semantics on PE/COFF.
@bob-wilson bob-wilson requested a review from compnerd April 25, 2019 16:27
@bob-wilson
Copy link
Contributor Author

@swift-ci please test

@bob-wilson bob-wilson mentioned this pull request Apr 25, 2019
Merged
compnerd
compnerd approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bob-wilson bob-wilson merged commit 263a6ea into swiftlang:swift-5.1-branch Apr 25, 2019
@bob-wilson bob-wilson deleted the rdar50110036-fix-windows branch April 25, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bob-wilson @compnerd