Skip to content

Revert "Add a benchmark for bridging String(contentsOfFile:...)" #24347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2019
Merged

Revert "Add a benchmark for bridging String(contentsOfFile:...)" #24347

merged 1 commit into from
Apr 27, 2019

Conversation

eeckstein
Copy link
Contributor

@eeckstein eeckstein merged commit 10087eb into master Apr 27, 2019
@eeckstein eeckstein deleted the revert-24326-string-from-file-benchmarks branch April 27, 2019 19:37
@milseman
Copy link
Member

CC @Catfish-Man, so he knows to reapply.

This is also why I think it's worth doing a full CI run, even for new benchmarks, even though it's annoying to have to wait half a day

@beccadax beccadax mentioned this pull request Apr 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eeckstein @milseman