[TypeChecker] Rephrase platforms in availability diagnostics #24334
Conversation
|
@swift-ci please test |
|
Build failed |
|
CI failure seems to be the bug fixed by #24347. |
|
@swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A part of swift::diagnoseExplicitUnavailability() that should never run for deprecations looks for them and handles them with “break”. Change this to llvm_unreachable() so we notice if this somehow happens. This change *should* be NFC; I’m splitting it out from other changes so that bisections can point to it if it causes problems in the future.
|
Linux CI failure should be fixed by apple/swift-clang#305. |
beccadax
force-pushed
the
wherefore-art-thou-api
branch
from
ac280ef to
30ed05f
Compare
|
@swift-ci please smoke test linux platform |
|
@swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
(To be clear, everything else is great. It's just that one message that's not great.) |
|
Going to squash all the fiddling down into a single commit, so brace for a force-push. |
This does several different things to improve how platforms are described in availability diagnostics: • Mentions the platform in diagnostics for platform-specific @available(unavailable) attributes. • Replaces “OS X” with “macOS”. • Replaces “fooOS application extension” with “application extensions for fooOS”. • Replaces “on fooOS” with “in fooOS”. Fixes <rdar://problem/49963341>.
beccadax
force-pushed
the
wherefore-art-thou-api
branch
from
1208f34 to
3494c0b
Compare
|
@swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
beccadax
changed the title
Not sure about this part; I really think "on" makes more sense. I would suggest something more context-sensitive:
|
|
@swift-ci smoke test |
|
I talked to @jakepetroules offline and he agreed to the "on" -> "in" change. The stars have finally aligned to land this. |
[TypeChecker] Rephrase platforms in availability diagnostics
This does several different things to improve how platforms are described in availability diagnostics:
• Mentions the platform in diagnostics for platform-specific @available(unavailable) attributes.
• Replaces “OS X” with “macOS”.
• Replaces “fooOS application extension” with “application extensions for fooOS”.
• Replaces “on fooOS” with “in fooOS”.
Fixes rdar://problem/49963341.
(If you want to review this, turn on "Hide whitespace changes" in the diff settings—this PR reindents a lot more code than it actually rewrites.)