Skip to content

[5.1] [TypeChecker] Rephrase platforms in availability diagnostics #24681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

beccadax
Copy link
Contributor

This PR cherry-picks #24334 to swift-5.1-branch. Master PR reviewed by @jrose-apple.

This does several different things to improve how platforms are described in availability diagnostics:

• Mentions the platform in diagnostics for platform-specific @available(unavailable) attributes.
• Replaces “OS X” with “macOS”.
• Replaces “fooOS application extension” with “application extensions for fooOS”.
• Replaces “on fooOS” with “in fooOS”.

Fixes rdar://problem/49963341.

(If you want to review this, turn on "Hide whitespace changes" in the diff settings—this PR reindents a lot more code than it actually rewrites.)

 [TypeChecker] Rephrase platforms in availability diagnostics
@beccadax
Copy link
Contributor Author

@swift-ci test

@beccadax beccadax merged commit 7e21820 into swiftlang:swift-5.1-branch May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant