Skip to content

[ModuleInterface] Include the raw values of @objc enums #24487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

[ModuleInterface] Include the raw values of @objc enums #24487

merged 1 commit into from
May 4, 2019

Conversation

jrose-apple
Copy link
Contributor

...since they're part of the run-time representation. Not having this meant that someone compiling against an interface would miscompile uses of @objc enums defined in that interface!

rdar://problem/50410541

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

harlanhaskins
harlanhaskins approved these changes May 3, 2019
View reviewed changes
Copy link
Contributor

@harlanhaskins harlanhaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@swift-ci
Copy link
Contributor

swift-ci commented May 3, 2019

Build failed
Swift Test Linux Platform
Git Sha - 66198905ee35b16d0a9d3d3b6e17593b57830dcc

@swift-ci
Copy link
Contributor

swift-ci commented May 3, 2019

Build failed
Swift Test OS X Platform
Git Sha - 66198905ee35b16d0a9d3d3b6e17593b57830dcc

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2019

Build failed
Swift Test Linux Platform
Git Sha - 66198905ee35b16d0a9d3d3b6e17593b57830dcc

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 66198905ee35b16d0a9d3d3b6e17593b57830dcc

@jrose-apple
[ModuleInterface] Include the raw values of @objc enums
cc5c04a 
...since they're part of the run-time representation. Not having this
meant that someone compiling against an interface would miscompile
uses of @objc enums defined in that interface!

rdar://problem/50410541
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - a4ec8be108f32efeba7cedd9b2d68e35ec3e6b0d

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2019

Build failed
Swift Test Linux Platform
Git Sha - a4ec8be108f32efeba7cedd9b2d68e35ec3e6b0d

@jrose-apple jrose-apple merged commit 9ba1d8a into swiftlang:master May 4, 2019
@jrose-apple jrose-apple deleted the overcooked branch May 4, 2019 17:14
jrose-apple added a commit to jrose-apple/swift that referenced this pull request May 4, 2019
@jrose-apple
[ModuleInterface] Include the raw values of @objc enums (swiftlang#24487
c234796 
)

...since they're part of the run-time representation. Not having this
meant that someone compiling against an interface would miscompile
uses of @objc enums defined in that interface!

rdar://problem/50410541
(cherry picked from commit 9ba1d8a)
@jrose-apple jrose-apple mentioned this pull request May 4, 2019
Merged
jrose-apple added a commit to jrose-apple/swift that referenced this pull request May 4, 2019
@jrose-apple
[ModuleInterface] Include the raw values of @objc enums (swiftlang#24487
2b54dd1 
)

...since they're part of the run-time representation. Not having this
meant that someone compiling against an interface would miscompile
uses of @objc enums defined in that interface!

rdar://problem/50410541
(cherry picked from commit 9ba1d8a)
@jrose-apple jrose-apple mentioned this pull request May 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

@nathawes nathawes nathawes approved these changes

@gottesmm gottesmm Awaiting requested review from gottesmm

@aschwaighofer aschwaighofer Awaiting requested review from aschwaighofer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jrose-apple @swift-ci @harlanhaskins @nathawes