Skip to content

[5.1 04-24] [ModuleInterface] Include the raw values of @objc enums #24501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

[5.1 04-24] [ModuleInterface] Include the raw values of @objc enums #24501

merged 1 commit into from
May 4, 2019

Conversation

jrose-apple
Copy link
Contributor

Cherry-pick of #24487 to the 04-24 5.1 branch, for Apple-internal clients. Reviewed by @harlanhaskins and @nathawes.

rdar://problem/50410541

@jrose-apple
[ModuleInterface] Include the raw values of @objc enums (swiftlang#24487
c234796 
)

...since they're part of the run-time representation. Not having this
meant that someone compiling against an interface would miscompile
uses of @objc enums defined in that interface!

rdar://problem/50410541
(cherry picked from commit 9ba1d8a)
@jrose-apple jrose-apple requested a review from a team as a code owner May 4, 2019 17:17
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple jrose-apple requested review from AnnaZaks and najacque May 4, 2019 17:17
@AnnaZaks AnnaZaks merged commit ecbf11d into swiftlang:swift-5.1-branch-04-24-2019 May 4, 2019
@jrose-apple jrose-apple deleted the 5.1-04-24-overcooked branch May 6, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZaks AnnaZaks AnnaZaks approved these changes

@najacque najacque Awaiting requested review from najacque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @AnnaZaks