Skip to content

[Build System: CMake] Update the default install_name_dir to /usr/lib/swift for the standard library and overlays (5.1 04-24-2019 branch). #24746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rostepher
Copy link
Contributor

Copy of #24382 for the 5.1 04-24-2019 branch.

rdar://46736483

Ross Bayer added 4 commits May 13, 2019 14:46
…e platforms (except for XCTest).

(cherry picked from commit 2123a42)
…ary install_name_dir. Those libraries are not going to be installed in /usr/lib/swift and thus need to be controlled via a separate mechanism.

(cherry picked from commit b855119)
…ary to DARWIN_INSTALL_NAME_DIR which better explains that this argument only controls the install_name_dir for Darwin platforms.

(cherry picked from commit dfb2d31)
@Rostepher Rostepher requested a review from a team as a code owner May 13, 2019 21:48
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 333a57e

…tLang module in SourceKit.

(cherry picked from commit d332d21)
@Rostepher
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 333a57e

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 333a57e

@Rostepher
Copy link
Contributor Author

This PR will require #24795.

@Rostepher
Copy link
Contributor Author

@swift-ci please test macOS Platform

@Rostepher Rostepher merged commit bb8528f into swiftlang:swift-5.1-branch-04-24-2019 May 16, 2019
@Rostepher Rostepher deleted the usr-lib-install-name-dir-5.1-04-24-2019 branch May 16, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants