Skip to content

[Build] Use magic linker symbols to specify an @rpath-relative install name when targeting pre-stable-ABI OSes (5.1 04-24-2019 branch). #24795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rostepher
Copy link
Contributor

Copy of #23451 for the 5.1 04-24-2019 branch.

mikeash added 2 commits May 14, 2019 18:10
…l name when targeting pre-stable-ABI OSes.

Magic symbols of the form $ld$install_name$os9.0$@rpath/libswiftCore.dylib tell the linker to use that install name when targeting that OS version. Use these symbols to specify an @rpath install name for all back-deployment libraries when targeting watchOS 2.0-5.1, iOS 7.0-12.1, and macOS 10.9-10.14.

rdar://problem/45027809
(cherry picked from commit 4fb9999)
@Rostepher Rostepher requested a review from a team as a code owner May 15, 2019 01:11
@Rostepher
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@bob-wilson bob-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@Rostepher Rostepher merged commit ea3d94e into swiftlang:swift-5.1-branch-04-24-2019 May 15, 2019
@Rostepher Rostepher deleted the magic-symbols-for-install-name-5.1-04-24-2019 branch May 15, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants