build: remove unnecessary property sets (NFC) #24827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @gottesmm @Rostepher |
|
Doesn't this provide the set of expected values? |
|
Turns out the |
|
@compnerd We should remove the one in |
compnerd
force-pushed
the
selling-properties
branch
from
4e6cfbf to
44254f9
Compare
|
@swift-ci please smoke test |
|
Aw, the CMake GUI is nice sometimes, though. |
|
@swift-ci please smoke test macOS platform |
|
@jrose-apple - yeah, it is nice sometimes, but the description already lists the expected values |
These properties are extraneous. They are never queried, and the `set(...CACHE)` which precedes them will ensure that the value is cached. This should be functionally equivalent.
compnerd
force-pushed
the
selling-properties
branch
from
44254f9 to
4d5470f
Compare
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are extraneous. They are never queried, and the
set(...CACHE)which precedes them will ensure that the value iscached. This should be functionally equivalent.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.